Account api gsi reversal v2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHjolany
requested review from
MirelaGeorgiou,
LBHMKeyworth,
rashmishetty1011 and
LBHSPreston
as code owners
HHjolany
requested review from
amidomichael,
AnnaGolosova,
EdwardAnoghena and
sandipchandra
AnnaGolosova
approved these changes
Nov 25, 2021
| if (!(request is GetPersonListRequest personListRequest)) | ||
| { | ||
| return null; | ||
| throw new ArgumentNullException($"{nameof(request).ToString()} shouldn't be null."); |
There was a problem hiding this comment.
Do we need ToString() call? I think an implicit conversion will be called
amidomichael
approved these changes
Nov 25, 2021
MirelaGeorgiou
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ClickUp ticket
https://app.clickup.com/t/1kcgq2e
Describe this PR
What is the problem we're trying to solve
due to requirement for the account search based on the "tenure id" (targetid = tenureid) without partition key, transferring of search by "targetId" to the Housing Seach API was needed. Hence, according to the single-purpose search instead of searching on all text fields, the HousingSearchRequest Class was chosen as an abstract class to prepare some ability to inherit some different Request Classes from that. and then in the new Request Class the possibility to achieve the single-purpose search option arised.
What changes have we introduced
The main housing search request was chosen as abstract class to give the child classes extension ability for single-purpose search
Checklist